-
Notifications
You must be signed in to change notification settings - Fork 34
[interop] Add Support for JSDoc Documentation #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # web_generator/lib/src/ast/declarations.dart # web_generator/lib/src/ast/helpers.dart # web_generator/lib/src/interop_gen/transform/transformer.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks Nike!
@srujzs – can be merged? |
…form refactored `generateFromDocumentation` for nullable docs and removed unnecessary add for annotations in `transformer.dart`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait to submit until we have CI no longer flaky again.
@srujzs after discussions, is it okay we merge this and then have a separate (draft) PR to fix this? |
I think that's fine, although I have no clue why it'd start being less flaky. |
Fixes #413
This PR adds support for parsing documentation for nodes/declarations in JSDoc and rewriting/providing them in a Dart-styled format, with support for
@link
references, annotations (@experimental
and@deprecated
for now), and more.Documentation is generated for all declarations where documentation is provided.